Cleanup modelCourse achievements.#2984
Draft
somiaj wants to merge 1 commit into
Draft
Conversation
Cleanup and update the default achievements in the modelCourse.
* Remove the same comment from the bottom of all evaluators.
This is hard to maintain, instead put all the information in
achievements_readme.txt and point to this file from other
evaluators.
* Cleanup the achievement evaluators:
* Simplify the code, don't use else statements when there was
a return inside the previous if. Clean up some of the logic.
* Take advantage of the new $globalData->{completedSets} hash
to avoid looping through all problems to determine if a
set is completed.
* Ran perltidy on them using an 80 character limit.
* Remove some evaluator duplication. The complete n problems
or n sets can all be done using a single evaluator, since
the only difference is the $maxCounter setting from the
achievement.
* Remove all unused achievement evaluators. There are lots of
these that are really just the same example achievement over
and over again to see if particular problems from particular
sets were completed. The images are still available for
helping people think of names, but the evaluators don't need
to be included. Instead provide four example evaluators for
completing specific problems and/or sets.
ca15f6b to
76c2363
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup and update the default achievements in the modelCourse.
Remove the same comment from the bottom of all evaluators. This is hard to maintain, instead put all the information in achievements_readme.txt and point to this file from other evaluators.
Cleanup the achievement evaluators:
Remove some evaluator duplication. The complete n problems or n sets can all be done using a single evaluator, since the only difference is the $maxCounter setting from the achievement.
Remove all unused achievement evaluators. There are lots of these that are really just the same example achievement over and over again to see if particular problems from particular sets were completed. The images are still available for helping people think of names, but the evaluators don't need to be included. Instead provide four example evaluators for completing specific problems and/or sets.
I still need to do a bit of testing on this, so making this a draft, but sharing so others can help test/give feedback.